adding description and url#1469
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
@rjeschmi: how about an (enhanced) unit test? see |
|
Jenkins: ok to test |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2328/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
don't hardcode /tmp/debug_fpm_mock, use $TMPDIR which will be a unique directory when the script it run (you can echo where you're debugging to), or at the very least use /tmp/$USER/debug_fpm_mock (but I strongly prefer using $TMPDIR)
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2339/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2340/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2341/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2342/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Looks good. Tests all pass now anyway... |
|
Thanks a lot @rjeschmi, great work on enhancing the tests! |
Adding description and url to fpm commandline
Will resolve: #1462