Generic compilation support by pescobar · Pull Request #1471 · easybuilders/easybuild-framework

pescobar · 2015-11-12T22:59:08Z

No description provided.

boegel · 2015-11-12T23:04:08Z

this should be a constant named GENERIC, that you import from easybuild.tools.toolchain.toolchain

hpcugentbot · 2015-11-12T23:28:21Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2324/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-11-13T19:51:49Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2335/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-11-13T20:08:34Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2336/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-11-13T21:51:41Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2337/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…ptarch' toolchain option)

fix --list-toolchains, always include generic flags (regardless of 'optarch' toolchain option)

boegel · 2015-11-19T05:07:53Z

Jenkins: test this please

hpcugentbot · 2015-11-19T06:41:47Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2355/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-11-20T06:07:13Z

@pescobar: this still needs:

enhanced unit test (see test_override_optarch in test/framework/toolchain.py)
docs update

rjeschmi · 2015-11-28T16:29:00Z

Is it worth supporting something in between generic and native?

pescobar · 2015-12-04T11:06:02Z

@rjeschmi I tried to build a software stack "in between" to use it as my generic software stack and I got problems.

My specific case was that I was compiling my "generic" software stack in the oldest cpu I had around which was a nehalem. I was building in the nehalem cpu with the default gcc option in easybuild of "-march=native" and I supposed that this would work in any other cpu but I found problems when trying to use this software stack in AMD cpus (magny-cours I think) and also when using it in xenserver virtual machines.

That's why I would suggest to build totally generic. I would focus this feature in portability and not in performance

pescobar · 2015-12-09T08:54:42Z

I did some tests and seems to be working for GCC. See this three build logs:

This one is a normal build without using --optarch
https://gist.github.com/61a9a47dc513e5bb4af2

This one is with --optarch=GENERIC and toolchainopts = {'optarch': True}
https://gist.github.com/6e1bf60e5e51a4ace7f5

This one is with --optarch=GENERIC and toolchainopts = {'optarch': False}
https://gist.github.com/e53fec626cae9c75d2ad

If you grep for "march" in those build logs all them seem fine for me.

Opinions @boegel ?

boegel · 2015-12-09T08:56:47Z

@pescobar: seems to be working indeed, so go ahead with the docs update

boegel · 2015-12-09T11:20:17Z

this should be self.COMPILER_OPTIMAL_ARCHITECTURE_OPTION = {

hpcugentbot · 2015-12-09T13:01:17Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2407/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-12-09T15:35:58Z

@pescobar: unit test + cleanup in pescobar#16

add unit test for --optarch=GENERIC + clean up way in which --optarch=GENERIC is handled

hpcugentbot · 2015-12-09T15:57:59Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2411/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-12-09T18:02:30Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2412/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-12-09T18:05:12Z

Going in, thanks @pescobar!

docs update at easybuilders/easybuild#172 will be included soon too

Generic compilation support

pescobar added 2 commits November 12, 2015 23:50

support optarch=GENERIC for gcc compiler

7f44bb6

add optarch=GENERIC support for intel compiler

bfdf0ac

boegel reviewed Nov 12, 2015
View reviewed changes

boegel modified the milestone: v2.5.0 Nov 13, 2015

pescobar added 3 commits November 13, 2015 20:44

added global var for generic build

da56c93

generic compilation flags for gcc

a98ff8e

generic compilation flags for intel compilers

798aeae

added missing import

29e4f5a

dont' overwrite OPTFLAGS when using generic

170a03c

fix --list-toolchains, always include generic flags (regardless of 'o…

e86c1c2

…ptarch' toolchain option)

boegel mentioned this pull request Nov 19, 2015

fix --list-toolchains, always include generic flags (regardless of 'optarch' toolchain option) pescobar/easybuild-framework#15

Merged

Merge pull request #15 from boegel/generic-compilation

4e3b0b0

fix --list-toolchains, always include generic flags (regardless of 'optarch' toolchain option)

boegel mentioned this pull request Nov 26, 2015

EasyBuild 2.5.0 (roadmap) easybuilders/easybuild#170

Closed

16 tasks

boegel reviewed Dec 9, 2015
View reviewed changes

added missing self.xxx

464d597

boegel added 2 commits December 9, 2015 15:50

add unit test for --optarch=GENERIC

1916459

clean up way in which --optarch=GENERIC is handled

4a963fe

boegel mentioned this pull request Dec 9, 2015

add unit test for --optarch=GENERIC + clean up way in which --optarch=GENERIC is handled pescobar/easybuild-framework#16

Merged

Merge pull request #16 from boegel/generic-compilation

5589038

add unit test for --optarch=GENERIC + clean up way in which --optarch=GENERIC is handled

+1

1d0903a

boegel added a commit that referenced this pull request Dec 9, 2015

Merge pull request #1471 from pescobar/generic-compilation

70c5fcc

Generic compilation support

boegel merged commit 70c5fcc into easybuilders:develop Dec 9, 2015

Conversation

pescobar commented Nov 12, 2015

Uh oh!

boegel Nov 12, 2015

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Nov 12, 2015

Uh oh!

hpcugentbot commented Nov 13, 2015

Uh oh!

hpcugentbot commented Nov 13, 2015

Uh oh!

hpcugentbot commented Nov 13, 2015

Uh oh!

boegel commented Nov 19, 2015

Uh oh!

hpcugentbot commented Nov 19, 2015

Uh oh!

boegel commented Nov 20, 2015

Uh oh!

rjeschmi commented Nov 28, 2015

Uh oh!

pescobar commented Dec 4, 2015

Uh oh!

pescobar commented Dec 9, 2015

Uh oh!

boegel commented Dec 9, 2015

Uh oh!

boegel Dec 9, 2015

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Dec 9, 2015

Uh oh!

boegel commented Dec 9, 2015

Uh oh!

hpcugentbot commented Dec 9, 2015

Uh oh!

hpcugentbot commented Dec 9, 2015

Uh oh!

boegel commented Dec 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants