hoist string value into a list in make_module_req#1502
hoist string value into a list in make_module_req#1502boegel merged 3 commits intoeasybuilders:developfrom
Conversation
|
It looks fine. Do we want to warn about it being a string instead of a list of just silently convert? |
|
Adding a warning doesn't hurt I guess, will do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2402/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2403/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Thanks for the review @wpoely86! |
hoist string value into a list in make_module_req
minor enhancement to avoid weird problems when passing a string value rather than a list
without this, you may run into an error like:
caused by
make_module_reqlooping over the string value as if it were a list...cc @wpoely86: please review?