PKG_CONFIG_PATH search extended to {lib,lib64,lib32,share}/pkgconfig#1505
PKG_CONFIG_PATH search extended to {lib,lib64,lib32,share}/pkgconfig#1505boegel merged 2 commits intoeasybuilders:developfrom
Conversation
There was a problem hiding this comment.
I'd prefer this (use os.path.join + alphabetical order):
'PKG_CONFIG_PATH': [os.path.join(x, 'pkgconfig') for x in ['lib', 'lib32', 'lib64', 'share']],There was a problem hiding this comment.
@boegel Why alphabetic? then should not be 'LIBRARY_PATH': ['lib', 'lib64', 'lib32'] also alphabetic?
And os.path.join for manpaht as well?
There was a problem hiding this comment.
@hajgato: style, mostly, the order should be changed for other stuff too, indeed
for 'share/man', it's a single string, not a composed string, but it doesn't hurt to also use os.path.join there
|
@boegel done |
|
@hajgato: thanks, look good, will merge when Jenkins gives the green light |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2415/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2416/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @hajgato! |
PKG_CONFIG_PATH search extended to {lib,lib64,lib32,share}/pkgconfig
No description provided.