[bugfix] only use glob in make_module_req on non-empty strings#1519
Merged
boegel merged 2 commits intoeasybuilders:developfrom Dec 16, 2015
Merged
[bugfix] only use glob in make_module_req on non-empty strings#1519boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
|
lgtm |
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Dec 16, 2015
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2449/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Member
Author
|
Jenkins: test this please |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2452/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
Author
|
Going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Dec 16, 2015
[bugfix] only use glob in make_module_req on non-empty strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for ancient bug that popped up in easybuilders/easybuild-easyblocks#758, which was introduced in #898 (March 2014!)
it managed to go undetected for a long time because only the CUDA easyblock passed empty string values via
make_module_req_guesstomake_module_req...cc @damianam