implement support for --new-pr and --update-pr (REVIEW) by boegel · Pull Request #1528 · easybuilders/easybuild-framework

boegel · 2015-12-30T00:15:03Z

adds support for eb --new-pr and eb --update-pr

results in PR like boegel/easybuild-easyconfigs#15

target account/repository can be controlled via --github-target-account and --github-target-repo (defaults to hpcugent and easybuild-easyconfigs)

title/description for new PR can be controlled using --pr-title and --pr-descr, resp.

commit message for new/updated PR can be controlled using --pr-commit-msg

boegel · 2015-12-30T00:15:46Z

fully functional, but may need some more options (e.g. --github-target-pr-branch which defaults to develop)

@wpoely86: up for giving this a test/review?

boegel · 2015-12-30T00:18:52Z

cc @pescobar

hpcugentbot · 2015-12-30T01:04:20Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2469/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-12-30T18:18:23Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2472/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-01-04T21:09:58Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2474/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86 · 2016-01-05T10:02:02Z

nit picking but maybe sort?

will do, thanks

…se they contain spaces

…fix push problem, include software name/version in branch name

hpcugentbot · 2016-01-05T20:28:24Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2475/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-01-20T21:31:04Z

some more (minor) enhancements + added unit tests + require --experimental

I believe this is ready to go in (still working on the docs update to go with this)...

@wpoely86: final review?

hpcugentbot · 2016-01-20T21:49:44Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2533/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-01-20T22:10:47Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2534/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-01-20T22:29:56Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2535/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-01-21T00:07:03Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2537/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2016-01-21T08:23:45Z

tests failed on Jenkins because of outdated GitPython installation on Jenkins, now updated to 1.0.1

Jenkins: test this please

hpcugentbot · 2016-01-21T08:34:08Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2540/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2016-01-21T08:43:38Z

Jenkins: test this please

hpcugentbot · 2016-01-21T09:31:23Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2542/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

wpoely86 · 2016-01-21T10:13:55Z

should this be in a try?

hpcugentbot · 2016-01-21T21:32:37Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2555/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…ferences" problem

hpcugentbot · 2016-01-22T08:53:20Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2559/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-01-22T10:27:45Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2560/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-01-22T13:39:14Z

I've opened/updated over a dozen of PRs with this already, and with the unit tests in place and the thorough review by @wpoely86, this is good to go.

To be clear: using --new-pr or --update-pr currently requires --experimental, since I'm expecting the interface to slightly chance as people provide feedback on this and when extending this to also easyblocks/framework is added.

Going in!

implement support for --new-pr and --update-pr (REVIEW)

implement support for --new-pr and --update-pr

35242b1

boegel added this to the v2.6.0 milestone Dec 30, 2015

add --github-target-branch

1a19d6b

add support for --pr-commit-msg, --pr-descr and --pr-title

a0bd227

wpoely86 reviewed Jan 5, 2016
View reviewed changes

boegel added 5 commits January 5, 2016 17:10

use "$@" to correctly handle option values that require quoting becau…

e4f7508

…se they contain spaces

correct default value for --github-target-branch to 'develop'

df6de4c

check return value for fetch() and push(), always do a full fetch to …

0a81891

…fix push problem, include software name/version in branch name

use read_file in retrieve_blocks_in_spec

55d533a

fix remarks

5aaf1dd

boegel added 2 commits January 6, 2016 20:58

add support for --git-working-dirs-path

b07a54c

make --new-pr/--update-pr dry-run-aware + improve output

61232a7

boegel added 2 commits January 20, 2016 22:26

fix --update-pr msg

f7c4323

add unit test for --new-pr/--update-pr

ca560fd

boegel changed the title ~~implement support for --new-pr and --update-pr (WIP)~~ implement support for --new-pr and --update-pr (REVIEW) Jan 20, 2016

require --experimental for --new-pr and --update-pr

a009708

fix log msg for --new-pr

2dc4fba

add --experimental to unit test for --new-pr/--update-pr

4591bf2

wpoely86 reviewed Jan 21, 2016
View reviewed changes

Comment thread easybuild/tools/github.py Outdated

Copy link
Copy Markdown

Member

wpoely86 Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in a try?

fix remarks

6c1f535

boegel added 2 commits January 22, 2016 09:00

Merge branch 'develop' into new_update_pr

ca0fbd2

switch to "full fetch" to try and fix "Remote ... did not have any re…

8cc9781

…ferences" problem

don't hardcode whitespace in test regexs for --new-pr/--update-pr

366e892

boegel added a commit that referenced this pull request Jan 22, 2016

Merge pull request #1528 from boegel/new_update_pr

2643e0e

implement support for --new-pr and --update-pr (REVIEW)

boegel merged commit 2643e0e into easybuilders:develop Jan 22, 2016

boegel deleted the new_update_pr branch January 22, 2016 13:39

Conversation

boegel commented Dec 30, 2015

Uh oh!

boegel commented Dec 30, 2015

Uh oh!

boegel commented Dec 30, 2015

Uh oh!

hpcugentbot commented Dec 30, 2015

Uh oh!

hpcugentbot commented Dec 30, 2015

Uh oh!

hpcugentbot commented Jan 4, 2016

Uh oh!

wpoely86 Jan 5, 2016

Choose a reason for hiding this comment

Uh oh!

boegel Jan 5, 2016

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Jan 5, 2016

Uh oh!

boegel commented Jan 20, 2016

Uh oh!

hpcugentbot commented Jan 20, 2016

Uh oh!

hpcugentbot commented Jan 20, 2016

Uh oh!

hpcugentbot commented Jan 20, 2016

Uh oh!

hpcugentbot commented Jan 21, 2016

Uh oh!

boegel commented Jan 21, 2016

Uh oh!

hpcugentbot commented Jan 21, 2016

Uh oh!

boegel commented Jan 21, 2016

Uh oh!

hpcugentbot commented Jan 21, 2016

Uh oh!

wpoely86 Jan 21, 2016

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Jan 21, 2016

Uh oh!

hpcugentbot commented Jan 22, 2016

Uh oh!

hpcugentbot commented Jan 22, 2016

Uh oh!

boegel commented Jan 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants