Skip to content

updating quotes for url#1530

Merged
boegel merged 4 commits intoeasybuilders:developfrom
rjeschmi:fixurl_quote
Jan 7, 2016
Merged

updating quotes for url#1530
boegel merged 4 commits intoeasybuilders:developfrom
rjeschmi:fixurl_quote

Conversation

@rjeschmi
Copy link
Copy Markdown
Contributor

a PR to fix #1527

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 31, 2015

Jenkins: ok to test

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 31, 2015

@rjeschmi: should we also use quote_str on other stuff? The software name could be something like Open|SpeedShop (yes, that's a thing, cfr. https://openspeedshop.org/) for example, which would also cause problems...

@boegel boegel added this to the v2.6.0 milestone Dec 31, 2015
@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2473/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 6, 2016

@rjeschmi: ping?

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2478/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Comment thread easybuild/tools/package/utilities.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also quote here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and also quoted the dep pkgname above.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2479/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 6, 2016

@rjeschmi: did you retest using --package with this in place? Just making very sure nothing broke here, since the unit tests only cover the EB side of things with a mocked fpm...

@rjeschmi
Copy link
Copy Markdown
Contributor Author

rjeschmi commented Jan 6, 2016

I tested it on goolf-1.7.20 which errored originally due to having homepage = '(none)'

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2480/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 7, 2016

Going in, thanks @rjeschmi and @pescobar for reporting the issue!

boegel added a commit that referenced this pull request Jan 7, 2016
@boegel boegel merged commit 18d43ef into easybuilders:develop Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants