Fix packaging to exclude logs and test reports#1544
Fix packaging to exclude logs and test reports#1544boegel merged 13 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
no need to break the import line here? if it's less than 120 chars, keep it on the same line
There was a problem hiding this comment.
same here, why wrap?
if you need to wrap, don't break the string:
raise EasyBuildError("Selected package naming scheme %s could not be found in %s",
sel_pns, avail_pns.keys())There was a problem hiding this comment.
It was a line length issue, both pep8 and pylint complain about it.
If we want to make a standard longer line I'm fine with that.
There was a problem hiding this comment.
our code style allows lines up until 120 chars, the default in pep8/pylint is 80 I think (which is a nightmare imho)
|
Jenkins: ok to test |
There was a problem hiding this comment.
use easyblock.installdir.lstrip(os.pathsep)
you have no idea what you're stripping off with [1:]
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2490/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
do this single line, with .append:
cmdlist.append('--debug')|
@rjeschmi: can we enhance the unit test(s) we have for the packaging support to check that logs/test report are not included? |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2491/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Also clean up some pylint complaints