Allow fixed install dir scheme#1546
Conversation
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
move this down, also mention the subdir itself in the log message? Also, ec is a dictionary, this will be a big/unreadable log message?
Both remarks fixed with this:
self.log.debug("Using fixed naming software installation subdir: %s (ec: %s)", subdir, ec)There was a problem hiding this comment.
move those outside the if/else? doesn't hurt to always print the subdir?
There was a problem hiding this comment.
Just thought the repetition was annoying
There was a problem hiding this comment.
this makes more sense to me:
if build_option('fixed_installdir_naming_scheme'):
self.log.debug("Using fixed naming for software installation subdir")
subdir = os.path.join(ec['name'], det_full_ec_version(ec))
else:
subdir = self.mns.det_install_subdir(self.check_ec_type(ec))
self.log.debug("Determined software installation subdir: %s (ec: %s)", subdir, ec)|
Jenkins: ok to test |
add unit test for --fixed-installdir-naming-scheme
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2492/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2493/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Download timed out |
|
Jenkins: test this please |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2494/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @ocaisa! |
This is fix for #1535 that defaults to keeping things as they are but adds the flexibility to use a fixed install scheme which would make it trivial to switch/trial other MNS