Drop dead code and fix bug (not using --job-cores in pbs_python)#1547
Merged
boegel merged 5 commits intoeasybuilders:developfrom Jan 14, 2016
Merged
Drop dead code and fix bug (not using --job-cores in pbs_python)#1547boegel merged 5 commits intoeasybuilders:developfrom
boegel merged 5 commits intoeasybuilders:developfrom
Conversation
The decorator gets executed in _check_version
Member
|
lgtm, is this related to #1523 at all? |
Member
Author
|
Yes, I discovered this on the road to fixing #1523 |
It was not used in the pbs_python backend
Member
Author
Member
|
@wpoely86: please update PR title to reflect that? |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2498/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
Author
|
@boegel ready to merge. Tested with our PBS systems and it works. I didn't test gc3pie. |
Member
|
Please test GC3Pie too? Can we enhance the unit tests, so we catch this if it occurs again in the future ( |
Member
Author
|
The unit tests are already extended |
Member
Author
|
@boegel GC3Pie works too. |
Member
|
Thanks @wpoely86! |
boegel
added a commit
that referenced
this pull request
Jan 14, 2016
Drop dead code and fix bug (not using --job-cores in pbs_python)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decorator gets executed in _check_version