check whether dependencies marked as external module are hidden#1552
check whether dependencies marked as external module are hidden#1552boegel merged 2 commits intoeasybuilders:developfrom
Conversation
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2516/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@wpoely86: please review? |
|
lgtm |
|
Maybe add test? 😈 |
|
@wpoely86: unit test (case) added |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2526/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Thanks for the review @wpoely86! @DirkdeDraak: do keep us posted whether this solves the problem you reported |
check whether dependencies marked as external module are hidden
fixes issue reported in easybuilders/easybuild#185
@DirkdeDraak: can you check whether the problem you reported is fixed with this patch (which is a better place to handle it than the patch you proposed imho)?