implement support for --modules-header#1558
Conversation
|
@wpoely86: please review? |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2527/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2530/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
why the not None? if it's empty, that's also trouble?
There was a problem hiding this comment.
the default value is None; if it's empty, you're doing something weird (e.g. use eb --modules-header='', and you deserve to know you did something wrong?
You will get a proper error via read_file in that case, which is certainly better than just ignoring this and leaving people wondering why it doesn't work.
|
lgtm |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2541/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Thanks for the review @wpoely86! |
implement support for --modules-header
fixes easybuilders/easybuild#186