Skip to content

add extra test for --include-easyblocks for generic easyblocks#1562

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:include_generic_easyblocks_test
Jan 22, 2016
Merged

add extra test for --include-easyblocks for generic easyblocks#1562
boegel merged 5 commits intoeasybuilders:developfrom
boegel:include_generic_easyblocks_test

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 21, 2016

test case for an unintended yet very useful side-effect of a fallback mechanism in get_easyblock_class

pointed out by @gppezzi

@boegel boegel added this to the v2.6.0 milestone Jan 21, 2016
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 21, 2016

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2552/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 21, 2016

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2553/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 21, 2016

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2556/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 22, 2016

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2558/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 22, 2016

@wpoely86: please review?

wpoely86
wpoely86 reviewed Jan 22, 2016
View reviewed changes
Comment thread test/framework/options.py
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend this comment a bit more about why this works

Copy link
Copy Markdown
Member Author

@boegel boegel Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jan 22, 2016

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2561/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 22, 2016

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Jan 22, 2016
@boegel
Merge pull request #1562 from boegel/include_generic_easyblocks_test
218c8ad 
add extra test for --include-easyblocks for generic easyblocks
@boegel boegel merged commit 218c8ad into easybuilders:develop Jan 22, 2016
@boegel boegel deleted the include_generic_easyblocks_test branch January 22, 2016 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86