changed default for dynamic (true) #1581
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
LGTM We basically should have included this already earlier. |
|
Jenkins: ok to test |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2613/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
why disable this? isn't it good to be a little bit verbose, so we know wth the wrappers are doing?
There was a problem hiding this comment.
The argument was that verbose was needed while TC was experimental, but now we could make it optional.
But you definitely have a point here since we lose the actual command line parameters behind the wrappers. Wrappers arguments are usually minimal and if we disable verbose I suppose we won't see on the logs all the includes, links and so on...
@pforai what do you think?
There was a problem hiding this comment.
OK, so let's revert verbose back to True, and merge this 
|
Same as you said, we could keep verbose but still leave dynamic set to True. I personally like verbosity in logs :) |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2616/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Thanks @gppezzi! |
changed default for dynamic (true)
No description provided.