easybuild is a namespace package (2nd attempt) (REVIEW)#1593
easybuild is a namespace package (2nd attempt) (REVIEW)#1593boegel merged 13 commits intoeasybuilders:developfrom
Conversation
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2630/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2631/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2632/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
9cf9762 to
df2fa05
Compare
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2633/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2634/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2635/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
I don't understand all the dark magic involved but it looks fine? At least, when jenkins agrees. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2646/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2650/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2651/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@wpoely86: please re-review? |
| """Test getting gcc version.""" | ||
| gcc_version = get_gcc_version() | ||
| self.assertTrue(isinstance(gcc_version, basestring) or gcc_version == UNKNOWN) | ||
| self.assertTrue(isinstance(gcc_version, basestring) or gcc_version == UNKNOWN or gcc_version is None) |
There was a problem hiding this comment.
when is it None? Should be UNKNOWN in that case no?
There was a problem hiding this comment.
There's no (real) GCC on OS X, then it's None (see also the tests below).
If gcc --version fails to run (exit code != 0), it's set to unknown.
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2703/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2797/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| zip_safe=False, | ||
| install_requires=["vsc-base >= 2.2.6"], | ||
| install_requires=[ | ||
| 'setuptools', |
There was a problem hiding this comment.
this should specify a minimal version
There was a problem hiding this comment.
the minimal required version is quite old, basically all we need is pkg_resources.declare_namespace and pkg_resources.fixup_namespace_packages; both are available in 0.6:
-bash-4.1$ python -c "import setuptools; print setuptools.__version__; from pkg_resources import declare_namespace, fixup_namespace_packages"
0.6
-bash-4.1$
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2834/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2852/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks for the feedback @wpoely86! |
easybuild is a namespace package (2nd attempt) (REVIEW)
|
|
||
| # extend path so Python knows this is not the only place to look for modules in this package | ||
| __path__ = extend_path(__path__, __name__) | ||
| pkg_resources.declare_namespace(__name__) |
There was a problem hiding this comment.
Maybe not, I don't really understand what's going on here
There was a problem hiding this comment.
Yeah, it's a bit of black magic.
another attempt at #1591 (after that was reverted in #1592)
PR tester has been enhanced, and should now see the problem reported in #1592 that warranted a rollback of #1591...
documentation on namespace packages is available at https://pythonhosted.org/setuptools/pkg_resources.html#namespace-package-support