Skip to content

define HOME constant that can be used in easyconfig files#1607

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:home
Feb 12, 2016
Merged

define HOME constant that can be used in easyconfig files#1607
boegel merged 2 commits intoeasybuilders:developfrom
boegel:home

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 11, 2016

This will allow use to get rid of import os; os.environ['HOME'] in easyconfig files...

@boegel boegel added this to the v2.7.0 milestone Feb 11, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 11, 2016

@wpoely86: please review

@wpoely86
Copy link
Copy Markdown
Member

lgtm

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2664/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2665/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 11, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2668/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2669/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 12, 2016

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Feb 12, 2016
define HOME constant that can be used in easyconfig files
@boegel boegel merged commit 82810cd into easybuilders:develop Feb 12, 2016
@boegel boegel deleted the home branch February 12, 2016 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants