Skip to content

fix availability check for external modules with partial module name#1634

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_avail_ext_mod_partial_modname
Feb 26, 2016
Merged

fix availability check for external modules with partial module name#1634
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_avail_ext_mod_partial_modname

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 26, 2016

required to make --robot --from-pr work on easybuilders/easybuild-easyconfigs#2554

without this, you run into this:

kehoste@daint102:~> eb --from-pr 2554 -dfr
== temporary log file in case of crash /tmp/eb-SCGaNv/easybuild-nBdPrL.log
== resolving dependencies ...
ERROR: Missing modules for one or more dependencies marked as external modules: ['PrgEnv-gnu', 'PrgEnv-gnu', 'PrgEnv-cray', 'PrgEnv-cray', 'PrgEnv-intel', 'PrgEnv-intel']

@boegel boegel added this to the v2.7.0 milestone Feb 26, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

cc @pforai, @gppezzi

@wpoely86
Copy link
Copy Markdown
Member

So the check is now independent whether it's hidden or not? lgtm

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

@wpoely86: yes, it basically fall backs to checking with module show in case the exact module name is not listed in the output of module avail

This occurs for hidden modules (e.g. .foo/1.2.3) and external modules with a partial module name (e.g. checking if PrgEnv-gnu is available, while avail spits out PrgEnv-gnu/5.2.40).

There's no harm in always falling back to show, except for maybe making things slower (modtool.exist will also check via avail first).

Maybe I should add an extra named argument to modtool.exist to specify that it should skip the avail check?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

@wpoely86: done, please rereview? Using skip_avail=True makes sense anywhere where only a single module name is provided (show is likely faster than avail in the case)

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2778/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Feb 26, 2016

I confirm that this PR is working (see reports on easybuilders/easybuild-easyconfigs#2554)

thx @boegel

@wpoely86
Copy link
Copy Markdown
Member

👍

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2779/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

Going in, thanks for the review @wpoely86 and feedback @gppezzi!

boegel added a commit that referenced this pull request Feb 26, 2016
fix availability check for external modules with partial module name
@boegel boegel merged commit 82bae4f into easybuilders:develop Feb 26, 2016
@boegel boegel deleted the fix_avail_ext_mod_partial_modname branch February 26, 2016 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants