No need to care about multiple versions of dummy#1646
No need to care about multiple versions of dummy#1646boegel merged 12 commits intoeasybuilders:developfrom
Conversation
...and also need to handle case where dependency easyconfig does not exist
Argh, pasted to the wrong place
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2806/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@ocaisa: is it worth enhancing the tests for the multiple-dummy-versions issue? |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2807/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2808/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2809/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2810/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| if subtoolchain_name == DUMMY_TOOLCHAIN_NAME: | ||
| # Don't care about multiple versions of dummy, take whatever comes first | ||
| _log.info("Ignoring multiple versions of %s in toolchain hierarchy", DUMMY_TOOLCHAIN_NAME) | ||
| subtoolchain_version = dep_tcs[0]['version'] |
There was a problem hiding this comment.
hmm, rather than leaving this to chance, wouldn't it be better to use '' as version? we know that using dummy as version has implications (i.e. deps not being loaded at build time)
There was a problem hiding this comment.
Can do but it actually has no impact, it's only used for resolving the easyconfig file name which in the case of dummy doesn't matter. What's inside the easyconfig file still gets used in a build process
enhance two-version dummy test case
Default to empty version for dummy toolchain
|
lgtm, ok to go in when Jenkins gives green light |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2815/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2816/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
fix md5sum for gzip-1.4.eb
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2817/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2819/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @ocaisa! |
No need to care about multiple versions of dummy
...and also need to handle case where dependency easyconfig does not exist