Skip to content

handle allowed system deps during prepare_step rather than during parsing of easyconfig#1652

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:allow_system_deps
Mar 4, 2016
Merged

handle allowed system deps during prepare_step rather than during parsing of easyconfig#1652
boegel merged 1 commit intoeasybuilders:developfrom
boegel:allow_system_deps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 4, 2016

fix for bug reported by @ocaisa

If handling of system deps happens too early, it causes problems.

@ocaisa: can you detail on the issue you ran into?

@boegel boegel added this to the v2.7.0 milestone Mar 4, 2016
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Mar 4, 2016

I was trying out easybuilders/easybuild-easyconfigs#2621 and I ran into an issue with HMNS. Deep in it's list of dependencies there is a build dependency on xcb-proto, which inside has a system dependency for Python. For a hierarchical naming scheme the robot is the default and the naming scheme requires the easyconfig to be parsed, so the easyconfig of xcb-proto will always get parsed, even though it is not part of the build process for Python. EBROOTPYTHON was being set as the file was parsed, which was causing the build to stop hard because it thought the module was loaded.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2828/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 4, 2016

@ocaisa: can you retry that on top of this PR? It should fix the problem.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Mar 4, 2016

Fix works, thanks @boegel !

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 4, 2016

Great, thanks for the confirmation @ocaisa, going in!

boegel added a commit that referenced this pull request Mar 4, 2016
handle allowed system deps during prepare_step rather than during parsing of easyconfig
@boegel boegel merged commit c839e5d into easybuilders:develop Mar 4, 2016
@boegel boegel deleted the allow_system_deps branch March 4, 2016 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants