Fix running test suite test.framework.options on my EB install#1699
Merged
boegel merged 1 commit intoeasybuilders:developfrom Mar 25, 2016
Merged
Fix running test suite test.framework.options on my EB install#1699boegel merged 1 commit intoeasybuilders:developfrom
test.framework.options on my EB install#1699boegel merged 1 commit intoeasybuilders:developfrom
Conversation
…installation. Actual patch by @boegel but I'm commiting it since it's on my laptop.
|
Automatic reply from Jenkins: Can I test this? |
Member
|
Thanks @riccardomurri! Jenkins: ok to test |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2906/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
|
Going in, thanks again @riccardomurri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual patch by @boegel but I'm commiting it since it's on my laptop.
edit (by @boegel): to clarify: this fixes the problem where the easyblocks from the EasyBuild installation were being picked up by the
test_include_easyblocks*tests, even though thesetUpof each tests tries to isolate the tests from non-test easyblocks...The problem was that the original
sys.pathis being restored in the middle of thetest_include_easyblocks*tests, which potentially reinstated the location to non-test easyblocks in the Python search path, breaking the 2nd part of these tests.