Skip to content

Remove purge from the tests #1702

Merged
boegel merged 2 commits intoeasybuilders:developfrom
pforai:patch-3
Mar 25, 2016
Merged

Remove purge from the tests #1702
boegel merged 2 commits intoeasybuilders:developfrom
pforai:patch-3

Conversation

@pforai
Copy link
Copy Markdown
Contributor

@pforai pforai commented Mar 25, 2016

in Analogy to #1608

boegel and others added 2 commits March 20, 2016 14:11
This shouldn't be needed as the environment is restored anyway. This is analog to #1608.
@boegel boegel mentioned this pull request Mar 25, 2016
@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2908/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.8.0 milestone Mar 25, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2016

I can't come up with any style remarks for this, and Jenkins is happy about it, so I guess I'll need to just go ahead and merge this... ;-)

This makes perfect sense, since the original environment is being restored in tearDown after each test, and module purge is 'dangerous' in the sense that it may break the environment, cfr. the problem with eb not being found in #1685.

So, going in, thanks @pforai!

@boegel boegel merged commit fd95c77 into easybuilders:develop Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants