Skip to content

escape special characters in software name in find_related_easyconfigs#1726

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_find_related_easyconfigs
Apr 18, 2016
Merged

escape special characters in software name in find_related_easyconfigs#1726
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_find_related_easyconfigs

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 18, 2016

This problem manifested itself when using --review-pr on a PR that contains an easyconfig with ++ in the software name, e.g.:

$ eb --review-pr 2905          
== temporary log file in case of crash /var/folders/8s/_frgh9sj6m744mxt5w5lyztr0000gn/T/eb-2b6bbB/easybuild-F9w0TY.log
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/Users/kehoste/work/easybuild-framework/easybuild/main.py", line 408, in <module>
    main()
  File "/Users/kehoste/work/easybuild-framework/easybuild/main.py", line 271, in main
    cleanup_and_exit = handle_github_options(options, orig_paths)
  File "/Users/kehoste/work/easybuild-framework/easybuild/main.py", line 174, in handle_github_options
    print review_pr(options.review_pr, colored=options.color)
  File "/Users/kehoste/work/easybuild-framework/easybuild/framework/easyconfig/tools.py", line 474, in review_pr
    files = find_related_easyconfigs(repo_path, ec['ec'])
  File "/Users/kehoste/work/easybuild-framework/easybuild/framework/easyconfig/tools.py", line 448, in find_related_easyconfigs
    res = [p for p in potential_paths if re.match(regex, p)]
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py", line 141, in match
    return _compile(pattern, flags).match(string)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py", line 251, in _compile
    raise error, v # invalid expression
sre_constants.error: multiple repeat

@boegel boegel added this to the v2.8.0 milestone Apr 18, 2016
@wpoely86
Copy link
Copy Markdown
Member

👍

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2939/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit dd3abf6 into easybuilders:develop Apr 18, 2016
@boegel boegel deleted the fix_find_related_easyconfigs branch April 18, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants