Add read permission to all installed files for everybody#1731
Add read permission to all installed files for everybody#1731boegel merged 5 commits intoeasybuilders:developfrom
Conversation
If nothing is specified, all installed files will have read permissions for everybody.
| perms = stat.S_IWGRP | stat.S_IWOTH | ||
| adjust_permissions(self.installdir, perms, add=False, recursive=True, relative=True, ignore_errors=True) | ||
| self.log.info("Successfully removed write permissions recursively for group/other on install dir.") | ||
| # add read permissions for everybody on all files |
There was a problem hiding this comment.
more like: make sure read permissions for everyone are in place, because usually they're already there...
There was a problem hiding this comment.
that boils down to exactly the same?
|
Should be fine imho, because that's what you'd usually expect. @pescobar, @fgeorgatos, @ocaisa, @rjeschmi: thoughts? |
|
Sounds good to me. I wonder what a system would look like that restricted permissions. You'd probably have to do a lot more throughout the module hierarchy to make it work usefully. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2949/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2950/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@wpoely86 broken tests are fixed with wpoely86#20 |
take into account group setting & fix interpretation of umask
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2998/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @wpoely86! |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2999/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
oops, didn't mean to close, finger slipped... :) |
If nothing is specified, all installed files will have read permissions
for everybody.
edit: we ran into this with VarScan, where the
.jarwas only readable for the install user