Skip to content

fix chdir in sanity check for extensions#1748

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_chdir_ext
Apr 30, 2016
Merged

fix chdir in sanity check for extensions#1748
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_chdir_ext

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 30, 2016

introduced in #1746

self.master is not defined for extensions that are being installed stand-alone (via ExtensionEasyblock), see below

self.installdir is always defined though, since Extension is only instantiated through ExtensionEasyblock, which ensures self.installdir is defined as self.master.installdir for extensions

 File "/user/scratchdelcatty/gent/gvo000/gvo00002/vsc40023/easybuild_easy_installed/lib/python2.6/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/main.py", line 114, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/user/scratch/gent/vsc400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2302, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/user/scratch/gent/vsc400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2218, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/user/scratch/gent/vsc400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2097, in run_step
    step_method(self)()
  File "/user/scratch/gent/vsc400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/framework/extensioneasyblock.py", line 121, in sanity_check_step
    sanity_check_ok = Extension.sanity_check_step(self)
  File "/user/scratch/gent/vsc400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-2.8.0.dev0-py2.7.egg/easybuild/framework/extension.py", line 121, in sanity_check_step
    os.chdir(self.master.installdir)
AttributeError: 'RubyGem' object has no attribute 'master'
 (at easybuild/main.py:147 in build_and_install_software)

@boegel boegel added this to the v2.8.0 milestone Apr 30, 2016
@boegel boegel mentioned this pull request Apr 30, 2016
Merged
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 30, 2016

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2991/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel merged commit 0fdc307 into easybuilders:develop Apr 30, 2016
@boegel boegel deleted the fix_chdir_ext branch April 30, 2016 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @hpcugentbot