Skip to content

translate PyPI download URL to alternate URL with a hash#1749

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:alt_pypi_url
May 7, 2016
Merged

translate PyPI download URL to alternate URL with a hash#1749
boegel merged 5 commits intoeasybuilders:developfrom
boegel:alt_pypi_url

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 2, 2016

PyPI was changed to use totally differently formatted URLs for new package versions, see also https://bitbucket.org/pypa/pypi/issues/438 .

This change implements auto-translating URLs like https://pypi.python.org/packages/source/e/easybuild/easybuild-2.7.0.tar.gz to https://pypi.python.org/packages/5b/03/e135b19fadeb9b1ccb45eac9f60ca2dc3afe72d099f6bd84e03cb131f9bf/easybuild-2.7.0.tar.gz .

This new style of URLs works for both old and new versions of Python packages, so this change should be transparent.

That is, until they utterly break things again, of course...

@boegel boegel added this to the v2.8.0 milestone May 2, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2016

@wpoely86 please review?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2016

cc @pescobar

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/3001/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented May 3, 2016

👍

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 7, 2016

slightly reworked to parse /simple/ HTML page using xml module, rather than 'parsing' it directly, as recommended at https://wiki.python.org/moin/PyPISimple

I also considered using the alternate JSON (https://wiki.python.org/moin/PyPIJSON) or XML-RPC (https://wiki.python.org/moin/PyPIXmlRpc) APIs, but these are less straightforward to use in this particular case because we don't have the package version readily available (unless we rework more of the code); we can easily extract the package name from the available URL though, which is sufficient for the Simple API.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/3005/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/3006/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/3007/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 7, 2016

Going in, thanks for the review @wpoely86!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants