Skip to content

set $LMOD_REDIRECT to 'no' when initialising Lmod#1755

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:LMOD_REDIRECT
May 10, 2016
Merged

set $LMOD_REDIRECT to 'no' when initialising Lmod#1755
boegel merged 1 commit intoeasybuilders:developfrom
boegel:LMOD_REDIRECT

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 10, 2016

cc @wpoely86

@rtmclay: always setting to $LMOD_REDIRECT to no to avoid Lmod redirecting output to stdout by issuing echo commands makes sense, right?

In EasyBuild, we want output messages to go to stderr since then we can separate them from the changes to the environment easily...

@boegel boegel added this to the v2.8.0 milestone May 10, 2016
@wpoely86
Copy link
Copy Markdown
Member

👍

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/3014/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2016

I don't see how this can break anything, tests are happy, and this is required if Lmod is configured to do redirection to avoid EB tipping over...

So, going in, thanks for the review @wpoely86!

(@rtmclay: please don't hesitate to drop in a comment even post-merge with your opinion on this)

@boegel boegel merged commit ab8f98c into easybuilders:develop May 10, 2016
@boegel boegel deleted the LMOD_REDIRECT branch May 10, 2016 17:29
@rtmclay
Copy link
Copy Markdown

rtmclay commented May 10, 2016

Yes, setting LMOD_REDIRECT=no will force Lmod to send module list etc to stderr independent of whether Lmod is configured to redirect or not.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2016

Thanks for the feedback @rtmclay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants