Skip to content

(re)load modules for build deps in extensions_step#1762

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:builddeps_exts
May 13, 2016
Merged

(re)load modules for build deps in extensions_step#1762
boegel merged 3 commits intoeasybuilders:developfrom
boegel:builddeps_exts

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 13, 2016

fix for issue #1741, see #1741 (comment) for more details

@damianam: can you verify whether this fixes your problem?

@boegel boegel added this to the v2.8.0 milestone May 13, 2016
@boegel boegel mentioned this pull request May 13, 2016
Closed
wpoely86
wpoely86 reviewed May 13, 2016
View reviewed changes
Comment thread easybuild/tools/toolchain/toolchain.py
"(found %s vs expected %s)", self.toolchain_dep_mods, toolchain_definition)

def prepare(self, onlymod=None, silent=False):
def prepare(self, onlymod=None, silent=False, loadmod=True):
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 May 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc arg

@damianam
Copy link
Copy Markdown
Member

damianam commented May 13, 2016

I've just tried. I can confirm it works for me.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 13, 2016

+1, tested it with the test case you provided in #1741, see also below (from log file for Perl/5.22.1-GCCcore-5.3.0):

thanks for the feedback @damianam and the review @wpoely86, going in!

$ egrep "Starting extension|Running module.*python load|List of loaded modules" $EBROOTPERL/easybuild/*log | head -10
== 2016-05-13 16:35:40,772 modules.py:599 DEBUG Running module command '/usr/bin/modulecmd python load GCCcore/5.3.0' from /tmp/vsc40023/easybuild_build/Perl/5.22.1/GCCcore-5.3.0/perl-5.22.1
== 2016-05-13 16:35:40,797 modules.py:599 DEBUG Running module command '/usr/bin/modulecmd python load binutils/2.26-GCCcore-5.3.0' from /tmp/vsc40023/easybuild_build/Perl/5.22.1/GCCcore-5.3.0/perl-5.22.1
== 2016-05-13 16:49:59,391 easyblock.py:2130 INFO Starting extensions step
== 2016-05-13 16:49:59,562 modules.py:599 DEBUG Running module command '/usr/bin/modulecmd python load Perl/5.22.1-GCCcore-5.3.0' from /vscmnt/gent_vulpix/_/user/data/gent/gvo000/gvo00002/vsc40023
== 2016-05-13 16:49:59,849 modules.py:599 DEBUG Running module command '/usr/bin/modulecmd python load binutils/2.26-GCCcore-5.3.0' from /vscmnt/gent_vulpix/_/user/data/gent/gvo000/gvo00002/vsc40023
== 2016-05-13 16:49:59,945 easyblock.py:1648 DEBUG Starting extension Config::General
== 2016-05-13 16:50:01,764 easyblock.py:1699 DEBUG List of loaded modules: [{'default': '(default)', 'mod_name': 'cluster/delcatty'}, {'default': None, 'mod_name': 'GCCcore/5.3.0'}, {'default': None, 'mod_name': '/Perl/5.22.1-GCCcore-5.3.0'}, {'default': None, 'mod_name': 'binutils/2.26-GCCcore-5.3.0'}]
== 2016-05-13 16:50:04,246 easyblock.py:1648 DEBUG Starting extension File::Listing
== 2016-05-13 16:50:04,362 easyblock.py:1699 DEBUG List of loaded modules: [{'default': '(default)', 'mod_name': 'cluster/delcatty'}, {'default': None, 'mod_name': 'GCCcore/5.3.0'}, {'default': None, 'mod_name': '/Perl/5.22.1-GCCcore-5.3.0'}, {'default': None, 'mod_name': 'binutils/2.26-GCCcore-5.3.0'}]
== 2016-05-13 16:50:05,036 easyblock.py:1648 DEBUG Starting extension ExtUtils::InstallPaths

@boegel boegel merged commit dad618b into easybuilders:develop May 13, 2016
@boegel boegel deleted the builddeps_exts branch May 13, 2016 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @damianam @wpoely86