Expand ~ in include paths#1774
Conversation
|
@tobbez patch looks great, thanks! To make this complete, we should add a test in Please let us know if you're up for this; if not, I can help out. |
|
@tobbez I implemented tests that check for this change in https://github.com/tobbez/easybuild-framework/pull/1, please review/merge. |
add/enhance tests to verify expanding of ~
|
@boegel Done. |
|
@tobbez thanks! Travis is reporting that one of the new tests fails, due to an oversight by me, which is fixed by https://github.com/tobbez/easybuild-framework/pull/2, can you please merge that too? Then this is good to go, I'll include it in the upcoming EasyBuild v2.8.1 (which will be released because of fixing #1775). |
compare *sorted* result of expand_glob_paths in test
|
Good to go, thanks @tobbez! |
Paths/globs specified to e.g.
--include-easyblocksare currently not expanded if they reference a home directory using ~ (e.g.--include-easyblocks=~/eb/block.pyor--include-easyblocks=~user/eb/block.py).This can get a bit confusing since specifying the path in the same way using the environment variable (
EASYBUILD_INCLUDE_EASYBLOCKS) works, because the ~ is expanded by the shell in that case.