add --avail-toolchain-opts#1830
Merged
boegel merged 5 commits intoeasybuilders:developfrom Jul 5, 2016
Merged
Conversation
|
|
||
| # dump known toolchain options | ||
| if self.options.avail_toolchain_opts: | ||
| msg += avail_toolchain_opts(str(self.options.avail_toolchain_opts), self.options.output_format) |
Member
|
@Caylo please add a comment in the PR with how the output looks like (both with |
| table_values = [ | ||
| ['``%s``' % opt_name for opt_name in tc_dict.keys()], | ||
| ['%s' % val[1] for val in tc_dict.values()], | ||
| ['``%s``' % val[0] for val in tc_dict.values()], |
Member
There was a problem hiding this comment.
two more problems here: sorting, and you have no strict guarantee that .values() will return things in the same key-order when being called twice
so, collect .items() before, and sort by key, then build up table_values
| """Show list of known options for given toolchain.""" | ||
| tc_class, _ = search_toolchain(name) | ||
| if not tc_class: | ||
| return "Couldn't find toolchain: '%s'. To see available toolchains, use --list-toolchains" % name |
Member
There was a problem hiding this comment.
please use raise EasyBuildError here (which will print to stderr and exit)
Member
|
Going in, thanks @Caylo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see easybuilders/easybuild#66
eb --avail-toolchain opts intel
eb --avail-toolchain opts intel --output-format=rst