handle deleted files in --new-pr#1853
Merged
boegel merged 13 commits intoeasybuilders:developfrom Aug 11, 2016
Merged
Conversation
Member
|
I would go with |
| from vsc.utils.missing import nub | ||
|
|
||
| from easybuild.framework.easyconfig.easyconfig import copy_easyconfigs | ||
| from easybuild.framework.easyconfig.easyconfig import copy_easyconfigs, process_easyconfig |
Member
There was a problem hiding this comment.
why import process_easyconfig if it's not being used?
Member
change logic to determine full path to files-to-delete in --from-pr
| if len(hits) == 1: | ||
| deleted_paths.append(hits[0]) | ||
| else: | ||
| raise EasyBuildError("Path doesn't exist or deleted file isn't found in target branch: %s", fn) |
| main_title = ', '.join(names_and_versions) | ||
| else: | ||
| main_title = ', '.join(names_and_versions[:3] + ['...']) | ||
| if file_info['ecs'] and any(file_info['new']): |
Member
There was a problem hiding this comment.
@Caylo this should be all(file_info['new']), no? We only want to auto-guess the title if all easyconfigs are new?
| main_title = ', '.join(names_and_versions) | ||
| else: | ||
| main_title = ', '.join(names_and_versions[:3] + ['...']) | ||
| if file_info['ecs'] and all(file_info['new']): |
Member
There was a problem hiding this comment.
also add and not deleted_paths, i.e. enforce picking a custom title with easyconfigs are added/removed in a single go
Member
|
Going in, thanks @Caylo! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usage:
eb --new-pr [path to deleted file]cfr #1674
includes #1867