Skip to content

ensure --show_hidden is used in the correct location for 'avail' with Lmod#1875

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_lmod_avail_show_hidden
Aug 16, 2016
Merged

ensure --show_hidden is used in the correct location for 'avail' with Lmod#1875
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_lmod_avail_show_hidden

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 12, 2016

fix for bug reported by @geimer

@boegel boegel added this to the v2.9.0 milestone Aug 12, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 12, 2016

@wpoely86 please review?


cmdlist = [self.cmd, 'python']

if args[0] in ('available', 'avail', 'list',):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

av?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EasyBuild never uses av as subcommand... (see implementation of available method)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 16, 2016

@wpoely86 any other remarks, or is this considered good to go?

@wpoely86
Copy link
Copy Markdown
Member

good to go for me

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 16, 2016

Thanks @wpoely86!

@boegel boegel merged commit 80aa0fb into easybuilders:develop Aug 16, 2016
@boegel boegel deleted the fix_lmod_avail_show_hidden branch August 16, 2016 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants