Target correct path when using bunzip2#1889
Merged
boegel merged 1 commit intoeasybuilders:developfrom Aug 26, 2016
sebth:develop
Merged
Target correct path when using bunzip2#1889boegel merged 1 commit intoeasybuilders:developfrom sebth:develop
boegel merged 1 commit intoeasybuilders:developfrom
sebth:develop
Conversation
The target path was not correctly used when calling bunzip2 to handle bzip2 files. Now bunzip2 is called the same way gunzip is called to handle gzip files.
Member
|
@sebth nice catch! Do you have an example easyconfig where you were hitting this problem with? |
Contributor
Author
|
@boegel: I have not found any in the repository, but I stumbled upon the bug when I wrote this: easyblock = 'BinariesTarball'
name = 'XDSSTAT'
version = '20151203'
homepage = 'http://strucbio.biologie.uni-konstanz.de/xdswiki/index.php/Xdsstat'
description = ('A home-brewn program that prints various statistics '
'(that are not available from XDS itself) in the form of '
'tables and images.')
source_urls = ['ftp://turn5.biologie.uni-konstanz.de/pub/']
sources = ['%(namelower)s-linux64.bz2']
checksums = ['ddf18f58aa191dec91e112dc14982b36']
# XDSSTAT binary is linked to GCC runtime.
toolchain = {'name': 'goolf', 'version': '1.7.20'}
dependencies = [('CCP4', '7.0')]
# Default sanity_check_paths dirs include both 'bin' and 'lib'.
# XDSSTAT has no 'lib'.
sanity_check_paths = {'files': [], 'dirs': ['bin']}
moduleclass = 'data' |
Member
|
Going in, thanks @sebth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct target path is not used when calling bunzip2 to handle
bzip2 files. This causes easyblocks such as BinariesTarball to fail for single bzip2 files.
To fix this problem, we can call bunzip2 the same way gunzip is called to handle gzip files. The gzip functionality has a test case to catch targeting errors, however the bzip2 functionality has not. We can add a similar test case to catch targeting errors for bzip2.