Skip to content

fix combining --extended-dry-run with --from-pr#1902

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:download_repo_x
Sep 12, 2016
Merged

fix combining --extended-dry-run with --from-pr#1902
boegel merged 4 commits intoeasybuilders:developfrom
boegel:download_repo_x

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 10, 2016

Without this patch, combining --from-pr with -x results in an error like:

EasyBuildError: '/tmp/eb-96zkBo/tmpaaRyAU/hpcugent/easybuild-easyconfigs-develop
should exist and contain the repo easybuild-easyconfigs at branch develop'

@boegel boegel added this to the v2.9.0 milestone Sep 10, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 10, 2016

@wpoely86 please review?

wpoely86
wpoely86 reviewed Sep 11, 2016
View reviewed changes
Comment thread easybuild/tools/filetools.py


def extract_file(fn, dest, cmd=None, extra_options=None, overwrite=False):
def extract_file(fn, dest, cmd=None, extra_options=None, overwrite=False, forced=False):
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document the new argument

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 12, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit 4631951 into easybuilders:develop Sep 12, 2016
@boegel boegel deleted the download_repo_x branch September 12, 2016 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86