Don't pass '--try-*' command-line options to EB instance running within job script#1908
Merged
boegel merged 4 commits intoeasybuilders:developfrom Sep 17, 2016
Merged
Don't pass '--try-*' command-line options to EB instance running within job script#1908boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Sep 16, 2016
| ignore_opts = ['robot', 'job'] | ||
| ignore_opts = ['robot', 'job', 'try-amend', | ||
| 'try-software', 'try-software-name', 'try-software-version', | ||
| 'try-toolchain', 'try-toolchain-name', 'try-toolchain-version'] |
Member
boegel
approved these changes
Sep 17, 2016
Member
|
Going in, thanks @geimer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As tweaking the easyconfigs is already done by the driver
ebinstance on the head node,--try-*command-line options don't need to be passed to the build instances running within the job scripts. Thus, filter them out. This shouldfixaddress #1475 (a shared--tmpdiris still needed as mentioned in #1355).Tested with
eb --try-toolchain=gompi,2016a LAPACK-3.4.2-gompi-1.5.12.eb --job; fails w/o the fix, succeeds with it.