Skip to content

convert all_dependencies to a property in EasyConfig class#1909

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:all_deps_property
Sep 15, 2016
Merged

convert all_dependencies to a property in EasyConfig class#1909
boegel merged 2 commits intoeasybuilders:developfrom
boegel:all_deps_property

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 15, 2016

This is mainly to avoid that the toolchain property is being accessed when an EasyConfig instance is created, since that i) is time-consuming, ii) can cause problems with 'special' toolchains like the Cray* toolchains, where a craype-<optarch> module must be available when the toolchain is instantiated (which is rather silly to do when just parsing the easyconfig file).

all_dependencies is only used in specific situations, i.e. when using --dep-graph, with --job --robot, and in --check-conflicts.

The proposed change ensures that all_dependencies is correctly defined when it's first accessed.

This will help speed up parsing of easyconfig files a little bit too.

@boegel boegel added this to the v2.9.0 milestone Sep 15, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 15, 2016

@wpoely86 please review

@wpoely86 wpoely86 changed the title covert all_dependencies to a property in EasyConfig class convert all_dependencies to a property in EasyConfig class Sep 15, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 15, 2016

Thanks @wpoely86!

@boegel boegel merged commit 3e0a554 into easybuilders:develop Sep 15, 2016
@boegel boegel deleted the all_deps_property branch September 15, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants