replace --use-compiler-cache with --use-ccache and --use-f90cache#1912
Merged
boegel merged 2 commits intoeasybuilders:developfrom Sep 16, 2016
Merged
replace --use-compiler-cache with --use-ccache and --use-f90cache#1912boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
wpoely86
reviewed
Sep 16, 2016
| if build_option('use_compiler_cache'): | ||
| self.prepare_compiler_cache() | ||
| # consider f90cache first, since ccache can also wrap Fortran compilers | ||
| for cache_tool in [F90CACHE, CCACHE]: |
Member
There was a problem hiding this comment.
should the list of all tools also be a global?
Member
Author
There was a problem hiding this comment.
it's only used in one place now, and it has to be in a specific order here, so I don't see the point in making it available globally? it'll make it harder to see why it's in a particular order
|
|
||
| # set paths that should be used by compiler caching tool | ||
| comp_cache_path = build_option('use_%s' % cache_tool) | ||
| setvar('%s_DIR' % cache_tool.upper(), comp_cache_path) |
Member
There was a problem hiding this comment.
are these values printed somewhere (for debug)?
Member
Author
There was a problem hiding this comment.
setvar will issue a log message (which is exactly why I switched to using setvar)
wpoely86
approved these changes
Sep 16, 2016
Member
Author
|
Thanks @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent version of
f90cachedoesn't support GCC 5.x, andccache3.3 supports Fortran(77).Besides that, it makes sense to split this up in order not to enforce using both
ccacheandf90cache, especially since the latter breaks Fortran compilation for recent GCC versions by doing anexitif the GCC version is too new (rather than acting as a fall through , which it should be doing).Since
--use-compiler-cacheis not included in a released EasyBuild version yet, I feel it's OK to make this change now.