monkey patch shell_quote in vsc.utils.generaloption to fix #1438#1915
Merged
boegel merged 4 commits intoeasybuilders:developfrom Sep 19, 2016
Merged
monkey patch shell_quote in vsc.utils.generaloption to fix #1438#1915boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
wpoely86
approved these changes
Sep 16, 2016
Member
wpoely86
left a comment
There was a problem hiding this comment.
ugly, but I haven't got time to do better
wpoely86
approved these changes
Sep 16, 2016
Member
Author
|
@geimer can you test whether this fixes your problem? It should... |
Contributor
Member
Author
|
@geimer great, thanks for confirming the workaround! Going in... |
|
should be fixed by hpcugent/vsc-base#257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(temporary) workaround for #1438, until hpcugent/vsc-base#151 can be fixed properly
cc @geimer