Skip to content

fix filtering loads for (hidden) build deps from generated module#1959

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_hidden_build_dep
Oct 17, 2016
Merged

fix filtering loads for (hidden) build deps from generated module#1959
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_hidden_build_dep

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 12, 2016

fix for #1850

@geimer please review/verify

@geimer
Copy link
Copy Markdown
Contributor

geimer commented Oct 15, 2016

@boegel Tested with the test case I provided in #1850 (with various combinations of deps listed as normal/build/hidden dependencies). Looks good to me.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 17, 2016

Thanks for the verification @geimer!

@boegel boegel merged commit 0e76b87 into easybuilders:develop Oct 17, 2016
@boegel boegel deleted the fix_hidden_build_dep branch October 17, 2016 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants