check that each glob pattern matches at least one file expand_glob_paths (important for --include-*)#1980
Merged
boegel merged 1 commit intoeasybuilders:developfrom Nov 8, 2016
Conversation
…ths (important for --include-*)
Member
Author
wpoely86
approved these changes
Nov 8, 2016
Member
|
Mmmh, I think my issue was different. I included a generic easyblock as any other easyblock, and that wasn't enough, it needed to be in the generic subdir. |
Member
Author
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was bitten by
--include-easyblockssilently not including specified easyblocks because I messed up the specified path a couple of times.This change fixes that, by making
expand_glob_paths, which is used (only) by the--include-*options, stricter to ensure at least one hit per specified glob pattern.