fix CUDA-related issues in HierarchicalMNS#1986
Merged
boegel merged 14 commits intoeasybuilders:developfrom Nov 10, 2016
Merged
fix CUDA-related issues in HierarchicalMNS#1986boegel merged 14 commits intoeasybuilders:developfrom
boegel merged 14 commits intoeasybuilders:developfrom
Conversation
Hierarchical MNS is broken with CUDA easyconfigs. This patch fixes a backtrace and installs CUDA in Core.
Must not indiscriminately add tc_comp_info to comp_versions, only add parts that comes from the list.
…el+cuda-toolchain' into fix_HMNS
…, also consider CUDA+icc/ifort (cfr easybuilders#1982)
Member
Author
|
This is (finally!) good to go, reviewed via #1753, #1982, #1976. Thanks for the feedback and help with this @thiell and @akesandgren! |
This was referenced Nov 10, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combination of #1753 and #1982 + relevant part of #1976 + fixing the use of CUDA with
dummytoolchainmakes #1086 obsolete
I also renamed some variables to try and make the code more readable, and added some clarifying comments.
cc @akesandgren, @thiell