avoid rewrapping already wrapped compiler/linker command with RPATH wrapper script#2022
Conversation
| Check whether command at specified location already is an RPATH wrapper script rather than the actual command | ||
| """ | ||
| in_rpath_wrappers_dir = os.path.basename(os.path.dirname(path)) == RPATH_WRAPPERS_SUBDIR | ||
| calls_rpath_args = 'rpath_args.py $CMD' in read_file(path) |
There was a problem hiding this comment.
The RPATH wrapper script that is in place is a templated version of easybuild/scripts/rpath_wrapper_template.sh.in. That doesn't mean we can't hash it, but I'd rather have a stupid yet safe check in place to really avoid wrapping an existing wrapper. We really really REALLY don't want to include a fork bomb in EasyBuild...
Checking a hash is really strict, you just need a single byte changed somehow to have a hash mismatch...
There was a problem hiding this comment.
Yes, so it's very very strict, like you want?
There was a problem hiding this comment.
I don't necessarily want the check to see whether the command I'm wrapping is a wrapper script already to be strict. On the contrary, I'd rather do a less strict non-hash check (like I'm doing now), which limits the chance of running into a false negative and wrapping an existing wrapper...
|
Thanks for the review @wpoely86! |
fix for #2010
cc @pescobar