make sure 'modules_tool' attribute is also defined for extensions#2026
Merged
boegel merged 2 commits intoeasybuilders:developfrom Nov 26, 2016
Merged
make sure 'modules_tool' attribute is also defined for extensions#2026boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
This was referenced Nov 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #2009
This is kind of a silly bug, since
self.modules_toolis used in thesanity_check_rpathmethod, but it gets only run for extensions for which custom paths/commands are specified in the corresponding easyblock (likenumpy).Making sure that
modules_toolis always defined makes sense, since that requirement may get introduced in other places as well at some point...