Skip to content

also skip dependencies of dependencies marked as external module in get_toolchain_hierarchy#2042

Merged
boegel merged 2 commits intoeasybuilders:eb302from
boegel:fix_get_toolchain_hierarchy_external_modules_dep
Dec 2, 2016
Merged

also skip dependencies of dependencies marked as external module in get_toolchain_hierarchy#2042
boegel merged 2 commits intoeasybuilders:eb302from
boegel:fix_get_toolchain_hierarchy_external_modules_dep

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 2, 2016 •
edited
Loading

fix for bug reported by @gppezzi

only occurs when dependencies of a toolchain include external modules as dependencies

edit: this completes the fix added in #1977

$ eb HDF5-1.8.15-gmvolf-15.11.eb -d
== temporary log file in case of crash /dev/shm/perettig/easybuild/stage/tmp/eb-Ao_Qb_/easybuild-D4bjgS.log
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/main.py", line 443, in <module>
    main()
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/main.py", line 328, in main
    easyconfigs, generated_ecs = parse_easyconfigs(paths)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/tools.py", line 378, in parse_easyconfigs
    ecs = process_easyconfig(ec_file, **kwargs)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 1257, in process_easyconfig
    ec = EasyConfig(spec, build_specs=build_specs, validate=validate, hidden=hidden)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 321, in __init__
    self.parse()
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 452, in parse
    self._finalize_dependencies()
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 903, in _finalize_dependencies
    tc = robot_find_minimal_toolchain_of_dependency(dep, self.modules_tool, parent_first=True)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 1396, in robot_find_minimal_toolchain_of_dependency
    toolchain_hierarchy = get_toolchain_hierarchy(parent_tc)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 128, in cache_aware_func
    toolchain_hierarchy = func(toolchain)
  File "/apps/common/UES/easybuild/software/EasyBuild/3.0.1/lib/python2.7/site-packages/easybuild_framework-3.0.1-py2.7.egg/easybuild/framework/easyconfig/easyconfig.py", line 193, in get_toolchain_hierarchy
    cands.append({'name': depdep['name'], 'version': depdep['version'] + depdep['versionsuffix']})
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

@boegel boegel added this to the 3.0.2 milestone Dec 2, 2016
@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Dec 2, 2016

Dry run works, I'll let you know if all the builds complete.

Thanks @boegel !

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 2, 2016

Thanks for verifying the fix @gppezzi!

@boegel boegel merged commit a8ea177 into easybuilders:eb302 Dec 2, 2016
@boegel boegel deleted the fix_get_toolchain_hierarchy_external_modules_dep branch December 2, 2016 14:35
boegel added a commit that referenced this pull request Dec 2, 2016
@boegel
Merge pull request #2043 from boegel/develop
ec1e6a8 
sync develop with eb302 branch w.r.t. #2042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @gppezzi