implement get_cpu_features function in systemtools#2074
Merged
boegel merged 4 commits intoeasybuilders:developfrom Jan 6, 2017
Merged
implement get_cpu_features function in systemtools#2074boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
JensTimmerman
approved these changes
Jan 5, 2017
JensTimmerman
left a comment
There was a problem hiding this comment.
this function isn't used anywhere?
| _log.debug("Trying to determine CPU features on Darwin via cmd '%s'", cmd) | ||
| out, ec = run_cmd(cmd, force_in_dry_run=True) | ||
| if ec == 0: | ||
| # returns clock frequency in cycles/sec, but we want MHz |
|
lgtm |
Member
Author
|
Thanks for the review @JensTimmerman! |
2 tasks
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Feb 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be used to implement an FFTW easyblock that auto-detects which configure flags can be specified to optimise performance (e.g.
--enable-avx,--enable-avx2, etc.), rather than hardcoding configure flags in the FFTW easyconfigs (which is an issue already, since--enable-sse2doesn't work on Linux/POWER for example).