Skip to content

fix traceback with 'eb --check-github' if GitPython is not installed#2085

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:check_github_no_git
Jan 16, 2017
Merged

fix traceback with 'eb --check-github' if GitPython is not installed#2085
boegel merged 1 commit intoeasybuilders:developfrom
boegel:check_github_no_git

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 14, 2017

fix for #1968

Output of eb --check-github with this patch included if GitPython is not available:

$ PYTHONPATH=$PWD:$HOME/work/vsc-base/lib eb --check-github
== temporary log file in case of crash /tmp/eb-AbfLV8/easybuild-auMOqN.log

Checking status of GitHub integration...

Making sure we're online... OK

* GitHub user... boegel => OK
* GitHub token... (no token found) => FAIL
* git command... OK ("git version 2.10.1 (Apple Git-78); ")
* GitPython module... FAIL (import failed)
* push access to boegel/easybuild-easyconfigs repo @ GitHub... FAIL (GitPython is not available)
* creating gists... FAIL (res: None)
* location to Git working dirs...  OK (/Users/kehoste/work)

One or more checks FAILed, GitHub configuration not fully complete!
See http://easybuild.readthedocs.org/en/latest/Integration_with_GitHub.html#configuration for help.

Status of GitHub integration:
* --from-pr: OK
* --new-pr: not supported
* --review-pr: OK
* --update-pr: not supported
* --upload-test-report: not supported

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 14, 2017

@wpoely86 please review?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 16, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit 7a9b8fe into easybuilders:develop Jan 16, 2017
@boegel boegel deleted the check_github_no_git branch January 16, 2017 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants