Skip to content

Skip check_trailing_whitespace test if pep8/pycodestyle is not available#2169

Merged
boegel merged 1 commit intoeasybuilders:developfrom
geimer:protect_test_check_trailing_whitespace
Mar 16, 2017
Merged

Skip check_trailing_whitespace test if pep8/pycodestyle is not available#2169
boegel merged 1 commit intoeasybuilders:developfrom
geimer:protect_test_check_trailing_whitespace

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Mar 16, 2017

It failed for me with

ERROR: test_check_trailing_whitespace (test.framework.style.StyleTest)
Test for trailing whitespace check.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/framework/style.py", line 91, in test_check_trailing_whitespace
    result = _eb_check_trailing_whitespace(line, lines, line_number, state)
  File "easybuild/framework/easyconfig/style.py", line 86, in _eb_check_trailing_whitespace
    result = trailing_whitespace(line)
NameError: global name 'trailing_whitespace' is not defined

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2017

Missed that indeed, thanks @geimer!

@boegel boegel added this to the 3.1.2 milestone Mar 16, 2017
@boegel boegel merged commit d92adb3 into easybuilders:develop Mar 16, 2017
@geimer geimer deleted the protect_test_check_trailing_whitespace branch March 17, 2017 07:53
boegel added a commit to boegel/easybuild-framework that referenced this pull request Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants