clarify error message when no software-specific easyblock was found#2178
Merged
boegel merged 2 commits intoeasybuilders:developfrom Mar 22, 2017
Merged
Conversation
wpoely86
approved these changes
Mar 22, 2017
Member
|
We should probably not break api during minor releases? |
Member
Author
|
@wpoely86 updated, please rereview? |
wpoely86
approved these changes
Mar 22, 2017
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a very cryptic error message like:
to:
I made a breaking change to the signature of
get_easyblock_classfor this, basically replacing thedefault_fallbackoptional argument witherror_on_missing_easyblock.Should I include a deprecation warning for that, which detects the use of
default_fallbackand assignserror_on_missing_easyblockinstead? Just in case this breaks a script that talks with the framework API?