add support for --verify-easyconfig-filenames#2185
Merged
boegel merged 3 commits intoeasybuilders:developfrom Mar 30, 2017
Merged
add support for --verify-easyconfig-filenames#2185boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
… specs optional argument to verify_easyconfig_filename
wpoely86
reviewed
Mar 30, 2017
| """ | ||
| if isinstance(parsed_ec, EasyConfig): | ||
| ecs = [parsed_ec] | ||
| ecs = [{'ec': parsed_ec}] |
Member
Author
There was a problem hiding this comment.
yes, and the enhanced test covers it now
| str, 'store', False, {'metavar': "PATH"}), | ||
| 'use-existing-modules': ("Use existing modules when resolving dependencies with minimal toolchains", | ||
| None, 'store_true', False), | ||
| 'verify-easyconfig-filenames': ("Verify whether filename of specified easyconfigs matches with contents", |
Member
Author
There was a problem hiding this comment.
No, that would change the behaviour, sites should enable this if they want to stricter behaviour.
I don't consider the flexibility of filenames for specified easyconfigs a bug, but a feature. I'd get annoyed fi EasyBuild gets picky about filenames when it doesn't really matter; it only really matters for the dependency resolver, which already complains if an easyconfig file that it picks up by filename doesn't contain what is expected.
We can reconsider this in EasyBuild v4.0, but I'm in favour of leaving the default behaviour as is.
wpoely86
approved these changes
Mar 30, 2017
Member
Author
|
Going in, thanks for the review @wpoely86 and the thumbs up @pneerincx |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by popular request...
cc @shahzebsiddiqui, @damianam, @pneerincx