add support for toolchain options like 'extra_cxxflags' to specify extra compiler options#2193
Conversation
|
@mboisson do we want to be able to specify separate/different flags for C and C++ compilers (i.e. in |
|
also, we're missing an enhanced test for this... |
It would be nice, but there is no current distinction between CFLAGS and CXXFLAGS in the code for any other parameters. I am not sure why this is the case, but the purpose of this PR is not to introduce such as split (even though I think there should be one). |
I have to say I'm lost when it comes to tests. Any pointers as to what I should do ? Extra arguments can be anything. There is no sample code that I can compile for anything. |
|
Any guidance as to how to create the missing tests ? |
|
@mboisson Examples of tests that check what goes into We should really extend this to cover Are you OK with not including this in EasyBuild v3.2.0 (which I hope to release next week)? |
|
Sure. We have merged it in our own fork anyway, so we are using it. |
|
Did you have time to extend on this ? |
|
@mboisson I'm afraid not, not sure when I'll find the time to flesh this out... |
|
@mboisson What is the status of this? Looks like we need to kick travis if we want to move forward on it... |
|
Mmm, the status is issue-necropsy :P I haven't touched this for two years. @boegel wanted some changes |
|
I discussed this with @boegel briefly last week, had forgotten you filed a PR... basically this is one of only two changes we have left in our fork (the other change pertains to the permissions of the temporary file folders He mentioned that a generic Neither of us is working this week though :) |
73bd76f to
af6d092
Compare
Also lets them start with a '-' and streamlines their handling.
|
Tested with Boost easyconfig from easybuilders/easybuild-easyconfigs#11642 that uses Thanks a lot both @mboisson and @bartoldeman! |
Tested with a NAMD recipe.