clean up easyconfigs that are copied for inclusion in pull request#2197
Merged
boegel merged 2 commits intoeasybuilders:developfrom May 18, 2017
Merged
clean up easyconfigs that are copied for inclusion in pull request#2197boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86 please review? |
wpoely86
reviewed
May 16, 2017
| :param paths: list of paths to easyconfigs to clean up | ||
| """ | ||
| regexs = [ | ||
| re.compile(r"^# Built with EasyBuild.*\n", re.M), |
Member
There was a problem hiding this comment.
why re.M? Do actually deleted the \n too?
Member
Author
There was a problem hiding this comment.
In this case re.M isn't required, I think you're right.
Can you clarify the question on the \n? If you're asking if that's deleted too, yes, it is, and it should be, otherwise you'll end up with a blank line?
Member
Author
There was a problem hiding this comment.
On 2nd thought, the re.M is required, to ensure that also a comment like # Built with EasyBuild... is filtered out if it doesn't occur on the 1st line (maybe the easyconfig was manually edited afterwards...).
wpoely86
approved these changes
May 18, 2017
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfr. #1674
enabled by default, can be disabled via
--disable-cleanup-easyconfigs